From: Florian Müllner <fmuellner@gnome.org>
Date: Mon, 16 Dec 2024 14:04:18 +0000 (+0100)
Subject: popupMenu: Make checkAccessibleState() private
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~177^2^2~11
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=43fa67884c1fb76b8e242ea032be947de6ab1ff6;p=gnome-shell.git

popupMenu: Make checkAccessibleState() private

Updating the accessible state is an internal business of the
class, so making it private is more appropriate.

Besides, it was never called from outside the class since it
was added in 2012, so it's unlikely we'll ever have a use case
for it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3576>
(cherry picked from commit 3421a3825a2ff8a35f0a2a3e7823f564d3746478)
---

diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index ddd6ce7ed..5f94fcabd 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -547,7 +547,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({
         this.bind_property('reactive', this._switch, 'reactive', GObject.BindingFlags.SYNC_CREATE);
 
         this.accessible_role = Atk.Role.CHECK_MENU_ITEM;
-        this.checkAccessibleState();
+        this._checkAccessibleState();
         this.label_actor = this.label;
 
         this.add_child(this.label);
@@ -578,7 +578,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({
             this.reactive = true;
             this.accessible_role = Atk.Role.CHECK_MENU_ITEM;
         }
-        this.checkAccessibleState();
+        this._checkAccessibleState();
     }
 
     activate(event) {
@@ -604,15 +604,15 @@ export const PopupSwitchMenuItem = GObject.registerClass({
 
     setToggleState(state) {
         this._switch.state = state;
-        this.checkAccessibleState();
+        this._checkAccessibleState();
     }
 
     _onToggled() {
         this.emit('toggled', this._switch.state);
-        this.checkAccessibleState();
+        this._checkAccessibleState();
     }
 
-    checkAccessibleState() {
+    _checkAccessibleState() {
         switch (this.accessible_role) {
         case Atk.Role.CHECK_MENU_ITEM:
             if (this._switch.state)